Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't compile ARIADNE as calibs are missing, speedup project historical.mif generation #1859

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • don't compile ARIADNE as calibs are missing -> make sure make test-coupled works again
  • avoid reading historical.mif multiple times, and don't extract all the other files from the archive
  • adjust some descriptions and units to align with coding style

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters merged commit 1a7d08b into remindmodel:develop Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants