Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new 45/NPi+NDC with EUR 2030, ELEVATE2p3 config, fix coupled tests, adjust units 2005->2017 #1851

Merged
merged 28 commits into from
Oct 7, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Oct 1, 2024

Purpose of this PR

  • new 45_carbonprice NPi2025_EUR55 (NPi from inputdata until 2025 and for EUR until 2030), and and NPiexpo realization (exponential growth from tax value before startyear)
  • add ELEVATE2p3 config and coupled config
  • inexplicable errors show up in REMIND if you accidentally tried to fix a run with cm_startyear = 2025 on another run with cm_startyear = 2030. The error was something with vm_deltaCap in 2025 for LAM being higher than its upper bound. So that does not seem to work, but there is also no warning about that. Now, REMIND fails transparently and early.
  • fix various SOF and EOF problems (missing, wrong filenames) and make sure in the tests that all files always have such lines. make test-fix and ./scripts/utils/SOFEOF now automatically corrects wrong filenames
  • don't trigger reload of input data if just some gdx files are missing (currently: SDPs)
  • adjust some 2005 -> 2017 for units, MAgPIE coupling, plot scripts, policy costs, damage calculation
  • fix failures of make test-coupled because the calibration uses regipol, but the test setting not, which lead to problems because some v47_ variable recently introduced failed

Type of change

  • Bug fix
  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters marked this pull request as draft October 1, 2024 11:26
@orichters orichters mentioned this pull request Oct 1, 2024
9 tasks
@orichters orichters changed the title new 45/NPi+NDC, ELEVATE2p3 config new 45/NPi+NDC with EUR 2030, ELEVATE2p3 config, fix coupled tests, adjust units 2005->2017 Oct 4, 2024
@orichters orichters marked this pull request as ready for review October 7, 2024 06:01
@orichters orichters merged commit 2d49f61 into remindmodel:develop Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants