-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new 45/NPi+NDC with EUR 2030, ELEVATE2p3 config, fix coupled tests, adjust units 2005->2017 #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orichters
changed the title
new 45/NPi+NDC, ELEVATE2p3 config
new 45/NPi+NDC with EUR 2030, ELEVATE2p3 config, fix coupled tests, adjust units 2005->2017
Oct 4, 2024
orichters
force-pushed
the
elevateclean
branch
from
October 4, 2024 15:41
550cfed
to
0d12430
Compare
orichters
force-pushed
the
elevateclean
branch
from
October 7, 2024 06:03
ceb3e96
to
6256bfe
Compare
RahelMA
approved these changes
Oct 7, 2024
laurinks
reviewed
Oct 7, 2024
laurinks
reviewed
Oct 7, 2024
laurinks
reviewed
Oct 7, 2024
LaviniaBaumstark
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
make test-fix
and./scripts/utils/SOFEOF
now automatically corrects wrong filenamesmake test-coupled
because the calibration uses regipol, but the test setting not, which lead to problems because somev47_
variable recently introduced failedType of change
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly