Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NDC update 2024-08-31 #1816

Merged
merged 1 commit into from
Sep 10, 2024
Merged

NDC update 2024-08-31 #1816

merged 1 commit into from
Sep 10, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Sep 9, 2024 •
edited
Loading

Purpose of this PR

Type of change

  • Minor change

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters merged commit bf98380 into remindmodel:develop Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaviniaBaumstark LaviniaBaumstark LaviniaBaumstark approved these changes

Assignees

@LaviniaBaumstark LaviniaBaumstark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orichters @LaviniaBaumstark