Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't automatically remove path_gdx_bau when 'not needed' #1809

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Sep 3, 2024

Purpose of this PR

  • partly undo Check if input_bau.gdx is given or really needed; a couple of minor changes mostly related to MAgPIE coupling #1366
  • Do not automatically remove path_gdx_bau, as this can be very confusing if you forget to adjust needBau when adding some call to input_bau.gdx
  • Drop the check completely in readCheckScenarioConfig, as it serves no purpose anymore if you don't remove the dependency here.
  • There is still a check in checkFixCfg which warns the user about it, but the removal has to be done manually.
  • Drop path_gdx_bau from some config files where not needed, and fix some typos there

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Copy link
Contributor

@dklein-pik dklein-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@orichters orichters merged commit 7ac92f4 into remindmodel:develop Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants