Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validateScenarios to output scripts #1790

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

pweigmann
Copy link
Contributor

@pweigmann pweigmann commented Aug 22, 2024

Purpose of this PR

This PR adds an output script to allow using piamValidation functions like validateScenarios() or validationReport directly from a REMIND directory.

Selecting the comparison option of Rscript output.R now offers validateScenarios. The number of runs to choose is not restricted, however the heatmap plots will likely have layout problems when a high number of scenarios is selected.
Currently, the only output that is generated is an .html report with interactive traffic-light heatmaps based on the validationConfig that is selected. In the future, other output options will be made available.

Type of change

  • New feature
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here: /p/tmp/pascalwe/remind_vs

@LaviniaBaumstark
Copy link
Member

what is a high number of scenarios?

@pweigmann
Copy link
Contributor Author

what is a high number of scenarios?

depends a bit on the number of regions/years/models - hard to give an estimate, maybe more than 6?

@pweigmann pweigmann marked this pull request as ready for review August 23, 2024 09:31
@pweigmann pweigmann requested review from LaviniaBaumstark and removed request for LaviniaBaumstark August 23, 2024 10:15
@pweigmann pweigmann merged commit 472a389 into remindmodel:develop Aug 23, 2024
2 checks passed
@pweigmann pweigmann deleted the integrateVS branch August 23, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants