Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocean alklinity enhancement #1777

Merged
merged 20 commits into from
Aug 21, 2024
Merged

Conversation

katarkow
Copy link
Contributor

@katarkow katarkow commented Aug 10, 2024

Purpose of this PR

  1. Add ocean alkalinity enhancement (OAE) to the CDR module. The option is off by default and can be added to the CDR portfolio via switch cm_33OAE.
  2. Since OAE is quite cheap, switching it on without limits might lead to infeasibilities, especially in end-of-century scenarios. There are no direct limitations, so I added it to quantity targets @Renato-Rodrigues such that esp Leon can limit global deployment.
  3. Together with remind2#629, this PR fixes the summation errors I introduced when separating atmospheric emissions from DAC and captured emissions from burning gas for DAC. @fschreyer
  4. Introduces capture rate of 90% for gas used for CDR which was missing so far. @strefler

Type of change

  • New feature
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed ( remind2#629)
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly
  • Test runs are here:
    SSP2-NPi: /p/tmp/katarkow/remind/OAE_6c9a0dd/output/SSP2-NPi_2024-08-01_18.51.03
    default SSP2-PkBudg650: /p/tmp/katarkow/remind/OAE_6c9a0dd/output/SSP2-PkBudg650_2024-08-01_20.28.50
    SSP2-PkBudg650 with OAE: /p/tmp/katarkow/remind/OAE_6c9a0dd/output/SSP2-PkBudg650_2024-08-01_20.28.50
  • Comparison of results (what changes by this PR?): /p/tmp/katarkow/remind/OAE_6c9a0dd/output/cs2_output/AMT_Pk650-Pk650-OAE_Pk650.pdf (The latest AMT from 18.07.24 18:16 does not include the transport sector changes merged by Johanna the same day at 20:59, so I'm not sure how helpful the comparison)

@katarkow katarkow merged commit 18a8032 into remindmodel:develop Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants