Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that manipulateConfig does not destroy comments and can undo changes #1767

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Aug 5, 2024

Purpose of this PR

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test): [ FAIL 0 | WARN 0 | SKIP 6 | PASS 88 ]
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters changed the title test that manipulateFile does not destroy comments. Needs lucode2#205 test that manipulateFile does not destroy comments and can undo changes Aug 6, 2024
@orichters orichters marked this pull request as ready for review August 6, 2024 12:05
@orichters orichters changed the title test that manipulateFile does not destroy comments and can undo changes test that manipulateConfig does not destroy comments and can undo changes Aug 6, 2024
@orichters orichters merged commit 5b3a3bc into remindmodel:develop Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants