-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New realizations diffExp2Lin and diffLin2Lin in 45_carbonprice #1723
Merged
laurinks
merged 2 commits into
remindmodel:develop
from
laurinks:carbon-price-trajectories
Jul 4, 2024
Merged
New realizations diffExp2Lin and diffLin2Lin in 45_carbonprice #1723
laurinks
merged 2 commits into
remindmodel:develop
from
laurinks:carbon-price-trajectories
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
orichters
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Overall, a great PR with detailed explanation 👍
- You might add some plots that might be helpful to quickly grasp what is going on, see picture below. The compareScenarios you linked might be deleted at some point, so it is good to have some basic information available on github.
- I would indeed add a short "45_carbonprice add realizations diffExp2Lin and diffLin2Lin" to the changelog
- I barely see a difference in carbon price for the 10 vs. 20 price differentiation (orange ellipse). Is that intended?
- The black arrows point to very substantial jumps in 2025 for a PkBudg500. Is that intended? Wasn't one of the ideas to have a smooth transition from 2020 to 2025?
laurinks
force-pushed
the
carbon-price-trajectories
branch
from
July 4, 2024 08:48
ccd1e54
to
02d4d0f
Compare
orichters
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly (to be judged by reviewers in needed)Further information (optional):
At Reviewers: It's my first pull request, so I am thankful for a careful check and for any feedback!
Further scenario comparison PDFs in comments below together with plots and explanations
(1) Exponential carbon pricing in end-of-century budget runs with different budgets (500, 650, 1050) and different carbon price differentiation spread (1, 10, 20): compScen-EocBudg-2024-07-02_12.57.31-H12.pdf
(2) Exponential carbon pricing in peak budget runs with different budgets (500, 650, 1050) and different carbon price differentiation spread (1, 10, 20): compScen-PkBudg-exp-2024-07-02_12.58.44-H12.pdf
(3) Comparison of linear and exponential carbon pricing in 650 peak budget runs with different carbon price differentiation spread (1, 10, 20): compScen-PkBudg650-2024-07-02_13.00.26-H12.pdf
(4) Comparison of linear and exponential carbon pricing in 1050 peak budget runs with different carbon price differentiation spread (1, 10, 20): compScen-PkBudg1050-2024-07-02_12.59.32-H12.pdf