Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move compareScenarios core framework to piamPlotComparison #1661

Merged
merged 13 commits into from
Apr 30, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Apr 22, 2024

Purpose of this PR

  • Adjust function calls after this refactoring of remind2
  • Updates /scripts/cs2/profiles.json to set new parameter projectLibrary
  • Updates function calls in various output scripts after moving functions from remind2 to piamPlotComparison and piamutils
  • Deletes no longer needed Ariadne output script and adjusts barplot years for Ariadne cs2 profile

Type of change

  • Refactoring
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I adjusted the reporting in remind2 where it was needed
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@fbenke-pik fbenke-pik changed the title Cs2 move compareScenarios core framework to piamPlotComparison Apr 26, 2024
@fbenke-pik fbenke-pik marked this pull request as ready for review April 29, 2024 10:22
@orichters
Copy link
Contributor

You might want to replace the calls to removePlus from piamInterfaces in scripts/output/single/checkProjectSummations.R as well by piamutils::deletePlus().

@fbenke-pik
Copy link
Contributor Author

You might want to replace the calls to removePlus from piamInterfaces in scripts/output/single/checkProjectSummations.R as well by piamutils::deletePlus().

Done

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: orichters <[email protected]>
@fbenke-pik fbenke-pik merged commit 0eb4cc1 into remindmodel:develop Apr 30, 2024
2 checks passed
@fbenke-pik fbenke-pik deleted the cs2 branch April 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants