Selectively revert 1620: Remove SE from dimension from industry for performance #1659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Pull request #1620 (with the follow-up #1641 and #1648) introduces a secondary energy dimension in subsector-specific industry FE demand.
It was designed to fix performance issues, but in fact convergence is better without it (see images below).
This is due to a flat optimum in the new dimension, as it does not make a difference which SE ends up in which subsector.
This PR reverts the main changes in these PRs while keeping some others, like a price change limit between calibration iterations.
Credit for all the performance tests go to @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q; Thanks for that!
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):
/p/tmp/pehl/Remind_selectively_revert_1620/output/
H12:
EU21: