-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if inputdata files are missing, try to download them. Add test. #1577
Conversation
tests still work: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make test is working including the new test, right?
f31_extraseed.cs4r | ||
*f31_decoffset.cs4r | ||
*f31_Xport.cs4r | ||
*f31_extraseed.cs4r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe delete those lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, as long as they are still called here, I think it is better just to comment them out:
$include "./modules/31_fossil/timeDepGrades/input/f31_decoffset.cs4r" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but they do not exist...and if yomeone would provide them, they would not be dirstributed as long as they would be commented in in this file. So, I think, it is better to have no outcommented code. If this will be reactivated, there are anyway code adjsutments necessary.
yes. |
Purpose of this PR
Current situation:
input/files
and then you need to manually restart input generationThis PR:
--gamscompile
to avoid that it tries to fix that over and over.make test
checks whether input data is complete--gamscompile
to avoid clutter in the terminalmissingInputData
and some changes to start scripts to allow them being called from testthat directoryA failing test looks like that:
Type of change
Checklist:
FAIL 0
in the output ofmake test
):[ FAIL 0 | WARN 0 | SKIP 6 | PASS 82 ]
CHANGELOG.md
has been updated correctly