Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't write rdata in test mode, improve start scripts #1500

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Dec 6, 2023

Purpose of this PR

  • don't write RData in test mode: until now, ./start.R --test and ./start_bundle_coupled.R --test write .Rdata files in the REMIND main folder, potentially affecting running cascades. That is not what a test should do.
  • facilitate selection of scenario config file: ./start.R NGFS_v4 will suffice
  • print start.R warnings instead of just telling there were many
  • improve error messages
  • make sure no-one ever uses the c_whatever and cm_whatever simultaneously

Type of change

  • Bug fix
  • Minor change to start scripts

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Copy link
Contributor

@dklein-pik dklein-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@orichters orichters marked this pull request as ready for review February 2, 2024 08:37
@orichters orichters merged commit d548fc8 into remindmodel:develop Feb 2, 2024
2 checks passed
@orichters orichters deleted the nordataintest branch February 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants