Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete old realizations of module 45_carbonprice #1480

Merged

Conversation

LaviniaBaumstark
Copy link
Member

@LaviniaBaumstark LaviniaBaumstark commented Nov 28, 2023

Purpose of this PR

clean up REMIND and delete old realizations of the module 45_carbonprice: NDC2constant, NPi2018, diffPhaseIn2Constant, diffPhaseIn2Lin, diffPhaseInLin2LinFlex, diffPriceSameCost

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@robertpietzcker
Copy link
Contributor

robertpietzcker commented Nov 28, 2023

could you add the list of deleted module realizations to the PR description? (with the 39 changed files this is not immediately clear :-)

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

  • All automated model tests pass (FAIL 0 in the output of make test) (except the know issue with EU21 runs)

… and test_99-codeCheck.R, which gets skipped if any of the previous tests failed.

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from my side. I think it would merit updating the changelog, so it is easier to find out later what happened to the realizations. I side with Robert on summarizing that in the PR description as well, that can help finding such information faster.

@orichters orichters changed the title delete old realizations of module 45_corbonprice delete old realizations of module 45_carbonprice Nov 28, 2023
@LaviniaBaumstark LaviniaBaumstark merged commit f0d6a6c into remindmodel:develop Nov 28, 2023
2 checks passed
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q added a commit to 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q/remind that referenced this pull request Nov 29, 2023
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q added a commit to 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q/remind that referenced this pull request Dec 1, 2023
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q added a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants