Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct percentage unit for pm_emiMktTarget_dev #1384

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

cchrisgong
Copy link
Contributor

so new unit is in % not 100%

Purpose of this PR

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • [X ] Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • [ X] My code follows the coding etiquette
  • [ X] I performed a self-review of my own code
  • [ X] I explained my changes within the PR, particularly in hard-to-understand areas
  • [ X] I checked that the in-code documentation is up-to-date
  • [ ]X I adjusted the reporting in remind2 where it was needed
  • [ X] I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • [ X] All automated model tests pass (FAIL 0 in the output of make test)
  • [ X] The changelog CHANGELOG.md has been updated correctly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check where this parameter is used, and adjust all instances where scaling it by two orders of magnitude has an effect on the model.

Or maybe just change the unit in the explanatory text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ends up in the documentation as

Description Unit
pm_emiMktTarget_dev(ttot, ttot2, ext_regi, emiMktExt) target deviation across iterations in current emissions divided by target emissions (1 is 100%)
pm_emiMktTarget_dev_iter(iteration, ttot, ttot2, ext_regi,emiMktExt) parameter to save pm_emiMktTarget_dev across iterations 1is100%

Maybe pick one formatting and stick to it.

@cchrisgong cchrisgong merged commit 1eed5c0 into remindmodel:develop Oct 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants