Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CAMPAIGNers scenarios #1373

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

robinhasse
Copy link
Contributor

@robinhasse robinhasse commented Aug 4, 2023

Purpose of this PR

Add two additional demand scenarios for CAMPAIGners with different levels of lifestyle changes

Type of change

  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@robinhasse
Copy link
Contributor Author

From the buildings side, we would need to add two new demScen scenarios for CAMPAIGNers. Not sure, if you would have needed that on you end @jmuessel?! Do you already know how you go about this in REMIND? Do you also need a new EDGE-T scenario?

@LaviniaBaumstark
Copy link
Member

what is the status of this PR? will you continue working on it?

@jmuessel
Copy link
Contributor

Yes, @robinhasse and I will talk about it today.

@jmuessel jmuessel merged commit f63bcb5 into remindmodel:develop Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants