Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmas-party: gamma & beta implementations from obsolete rand package #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thekondor
Copy link

Because rand to be dropped soon. Once we are done with this change, we could switch bm to use go-xorshift completely.

@thekondor thekondor self-assigned this Dec 16, 2020
@gburanov
Copy link
Contributor

@thekondor
Copy link
Author

@gburanov they are not used across the remaining repositories. Why do we need to keep them?

@gburanov
Copy link
Contributor

ok, my idea was that even if we are not using them, they belong here (they are also distributions)....

Also I do not really like the package name - it assumes we use xorshift for randomization, but this is just one of the strategies ...

What do you think of opposite approach? Move all the things from here to rand?

I think it will be more clear... WDYT?

@dynamix
Copy link
Contributor

dynamix commented Dec 17, 2020

go-xorshift exists because it extracted the random number generator from remerge/rand (+ the lock free UUIDs/URIs) . It should only that. Other libraries like remerge/rand can use it and still include the distributions.

Please keep in mind that this is a public repo :-) i.e. I used it in some none remerge random tests.

@thekondor
Copy link
Author

@dynamix since rand is public, looks like that doesn't have any sense to remove any part of it at all, because this can break someone's dependency. Though xorshift is mostly a superset of rand package (except ones mentioned by @gburanov).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants