Update dev dependencies #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was rewritten to use `node:test`.
remcohaszing
added
🦋 type/enhancement
ChristianMurphy
approved these changes
Aug 22, 2023
| const fs = require('node:fs/promises') | ||
| const path = require('node:path') | ||
|
|
||
| const {test} = require('node:test') | ||
| const {commands, extensions, window, workspace} = require('vscode') | ||
|
|
||
| module.exports.run = async () => { |
There was a problem hiding this comment.
does this still need to be wrapped in module.exports.run?
Could the tests be run at the top level?
There was a problem hiding this comment.
Yes. This is how @vscode/test-electron works. It references a CJS module that should have a run() function that returns a promise. I.e. using another framework means this function should call something like new Mocha() or jest.run(). node:test just happens to be simple. :)
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
The test was rewritten to use
node:test.