Add remark-code-title to list of plugins

[kevinzunigacuellar]

Signed-off-by: Kevin Zuniga Cuellar [email protected]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

Add remark-code-title plugin to list of plugins

[codecov-commenter]

Codecov Report

Merging #1076 (6ea9a1b) into main (c7e8171) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1076   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          901       907    +6     
=========================================
+ Hits           901       907    +6     

Impacted Files	Coverage Δ
packages/remark-parse/lib/index.js	100.00% <100.00%> (ø)
packages/remark-stringify/lib/index.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134ece2...6ea9a1b. Read the comment docs.

[wooorm]

Hey! Congrats on making your plugin :)

I think it can be better though: you should not inject strings of HTML into the AST.
There is an AST for HTML already. hast. You can create a rehype plugin to work on the HTML AST. I’d recommend that.
If you really need to work on markdown, you should use the embedded HTML AST: https://github.com/syntax-tree/mdast-util-to-hast#fields-on-nodes.

The return value of visit is a) not needed, b) incorrect. If you specify it, it should I believe be index + 1 instead.

[kevinzunigacuellar]

Hello @wooorm, thanks a lot for taking the time to give some feedback. I agree, injecting strings feels a bit hacky. I will update this using the mdast-hast util.

I will also explore the rehype plugin route but since the package is already published I will start that in a fresh repo. Again thanks a lot for the constructive feedback 🙌

[kevinzunigacuellar]

hello @wooorm sorry to bother you again. I applied the requested changes except for the return index + 1. When I changed this I ran into an infinite loop. I am not exactly sure what the reason behind this is, but I just wanted to let you know.

[ChristianMurphy]

Nice! Thanks for sharing.

An aside, for TypeScript + ESM, you may need "type": "module" in package.json, see https://2ality.com/2021/06/typescript-esm-nodejs.html for a guide on publishing ESM packages with TS.

[kevinzunigacuellar]

Nice! Thanks for sharing.

An aside, for TypeScript + ESM, you may need "type": "module" in package.json, see https://2ality.com/2021/06/typescript-esm-nodejs.html for a guide on publishing ESM packages with TS.

Thanks, I completely missed that

[kevinzunigacuellar]

Nice! Thanks for sharing.

An aside, for TypeScript + ESM, you may need "type": "module" in package.json, see https://2ality.com/2021/06/typescript-esm-nodejs.html for a guide on publishing ESM packages with TS.

fixed in version 0.2.2

Thanks again for the feedback. I am very new to publishing npm packages.

[wooorm]

Thanks! :)