Add missing dependency for types

[Methuselah96]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

Added dependencies on @types/prop-types and mdast-util-to-hast since they are used in the built declaration files and produce type errors without them:

ERROR in ../../.yarn/__virtual__/react-markdown-virtual-1089d10e66/0/cache/react-markdown-npm-8.0.0-3d725f3756-61412ecd18.zip/node_modules/react-markdown/lib/react-markdown.d.ts 47:32-56
TS2307: Cannot find module 'mdast-util-to-hast/lib' or its corresponding type declarations.
    45 |   remarkPlugins?: import('unified').PluggableList | undefined
    46 |   rehypePlugins?: import('unified').PluggableList | undefined
  > 47 |   remarkRehypeOptions?: import('mdast-util-to-hast/lib').Options | undefined
       |                                ^^^^^^^^^^^^^^^^^^^^^^^^
    48 | }
    49 | export type LayoutOptions = {
    50 |   className?: string | undefined

ERROR in ../../.yarn/__virtual__/react-markdown-virtual-1089d10e66/0/cache/react-markdown-npm-8.0.0-3d725f3756-61412ecd18.zip/node_modules/react-markdown/lib/react-markdown.d.ts 62:23-35
TS7016: Could not find a declaration file for module 'prop-types'. '/home/runner/work/ParagonCore/ParagonCore/.yarn/cache/prop-types-npm-15.8.1-17c71ee7ee-c056d3f1c0.zip/node_modules/prop-types/index.js' implicitly has an 'any' type.
  If the 'prop-types' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/prop-types'
    60 | }
    61 | import {uriTransformer} from './uri-transformer.js'
  > 62 | import PropTypes from 'prop-types'
       |                       ^^^^^^^^^^^^
    63 |

[codecov-commenter]

Codecov Report

Merging #675 (91ad6e9) into main (bd8e53b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #675   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          731       731           
=========================================
  Hits           731       731           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8e53b...91ad6e9. Read the comment docs.

[wooorm]

Suggested change

"mdast-util-to-hast": "^12.0.0",

Nice catch!
Could you solve the RemarkRehypeOptions by instead importing it from remark-rehype? That’s already a dependency

[Methuselah96]

The source is correctly importing it from remark-rehype. I created microsoft/TypeScript#48242 since it seems like a TypeScript bug.

[Methuselah96]

I've narrowed this PR to just add @types/prop-types for now. Hopefully the dependency on mdast-util-to-hast can be fixed in upstream.

[wooorm]

can be fixed in upstream.

This sounds like a pnp problem. Not related to TS?
Or is TS “flatting” it when generated types from JS?

[Methuselah96]

The higher-level issue is relying on package hoisting. 99% of the time this isn't an issue because the file structure will look like:

node_modules
|-mdast-util-to-hast@^12.0.0
|-react-markdown
|-remark-rehype

If mdast-util-to-hast@^1.0.0 is added as a dependency it now looks like:

node_modules
|-mdast-util-to-hast@^1.0.0
|-react-markdown
|-remark-rehype
  |-mdast-util-to-hast@^12.0.0

And react-markdown no longer has access to the correct types.

Therefore the TypeScript bug is that it's rewriting import('remark-rehype').Options as import('mdast-util-to-hast/lib').Options when it shouldn't. This is a potential problem for any package manager, Yarn PnP is just making it painfully obvious that there's an issue.

It seems unlikely that someone would add a dependency on mdast-util-to-hast@^1.0.0, that's just the easiest example to give. The more common cause of conflict is having workspaces and one app depends on react-markdown@^8.0.0 and the other depends on react-markdown@^7.0.0 and now you start having problems like this.

[wooorm]

Thanks, released!