Fix server error by updating Next.js Webpack config #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Error: Expected <div> to have explicit "display: flex" or "display: none" if it has more than one child node. ```
remarkablemark
commented
Jun 29, 2023
Comment on lines
+10
to
+15
| test: /html-react-parser\/index\.js$/, | ||
| resolve: { | ||
| alias: { | ||
| 'html-dom-parser': path.join(path.dirname(require.resolve('html-dom-parser')), 'lib/server/html-to-dom.js'), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Without setting this alias, Vercel/Webpack/PNPM tries to resolve the html-dom-parser client module (probably due to the browser field), which seems like a bug on their end
remarkablemark
commented
Jun 29, 2023
| @@ -11,6 +11,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@vercel/og": "latest", | |||
| "html-dom-parser": "^4.0.0", | |||
There was a problem hiding this comment.
Although not necessary, I installed html-dom-parser explicitly so I could do require.resolve('html-dom-parser') to get the module path
Alternatively, you can get the path with something like but it's less deterministic and can break when version is changed:
path.join(__dirname, 'node_modules/.pnpm/[email protected]/html-dom-parser/lib/server/html-to-dom.js')
remarkablemark
commented
Jun 29, 2023
|
|
||
| export const config = { | ||
| runtime: 'edge', | ||
| } | ||
|
|
||
| export default async function handler() { | ||
| const parsedText = parse('<div><p>Hello, World</p></div>') | ||
| const parsedText = parse('<div style="display: flex;"><p>Hello, World</p></div>') |
There was a problem hiding this comment.
I fixed the error:
Expected <div> to have explicit "display: flex" or "display: none" if it has more than one child node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Fix server error by updating Next.js Webpack config
Fixes #1
Relates to remarkablemark/html-react-parser#736 (comment)
What is the current behavior?
Server error: http://localhost:3000/api/og
What is the new behavior?
Page renders: http://localhost:3000/api/og
Checklist: