-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Typescipt and @typescript-eslint/parser #826
Conversation
@L4Ph When executing
|
Maybe adding the following to webpack.config.js will fix the problem. // webpack.config.js
// module.rules
{
test: /\.mjs$/,
include: /node_modules/,
type: 'javascript/auto',
} |
@L4Ph Thank you for the suggestion. Yes, I know that this issue will be solved when appending the definition into the webpack.config.js file. However, we can't have a webpack.config.js file because we're using the react-scripts currently. |
@yoichiro There are two possible approaches:
To be honest, the first point will cause the response to Vite to be increasingly delayed and there is a possibility that it will "break" the CRA. |
@L4Ph Yes, I feel same thing actually as well. I think that we need to progress forward to migrate "Webpack" to "Vite". That is, we should take a risk of failure of launching the server locally rather than supporting the Webpack5. Of course, to do that, we need to progress to support "Vite" quickly. If you agree my proposal, I merge this pull request. How about it? |
If that's okay with you, I support that too. |
@L4Ph Thank you for your contributions! I merge this pull request. Move forward to supporting Vite! |
"moduleResolution": "bundler"
が動作しないため、Typescriptをv5へアップグレードLine 0: Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead
というエラーを解消するために@typescript-eslint/parser
をv7へアップグレード