Merge pull request #847 from remap-keys/change-eslint-no-unused-vars-…

…error-checker

Fix no-unused-vars warnings.

eslint.config.mjs

@@ -6,6 +6,7 @@ import react from "eslint-plugin-react";
 import prettier from "eslint-plugin-prettier";
 import globals from "globals";
 import tsParser from "@typescript-eslint/parser";
+import tsEslint from "@typescript-eslint/eslint-plugin";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import js from "@eslint/js";
@@ -29,6 +30,7 @@ export default [...fixupConfigRules(compat.extends(
     plugins: {
         react: fixupPluginRules(react),
         prettier: fixupPluginRules(prettier),
+        "@typescript-eslint": tsEslint,
     },
 
     languageOptions: {
@@ -49,7 +51,6 @@ export default [...fixupConfigRules(compat.extends(
 
         parserOptions: {
             version: 2018,
-
             ecmaFeatures: {
                 jsx: true,
             },
@@ -61,7 +62,16 @@ export default [...fixupConfigRules(compat.extends(
             usePrettierrc: true,
         }],
 
-        "no-unused-vars": "warn",
+        "no-unused-vars": "off",
         "react/prop-types": "warn",
+        "@typescript-eslint/no-unused-vars": [
+          "warn",
+          {
+            "argsIgnorePattern": "^_",
+            "varsIgnorePattern": "^_",
+            "caughtErrorsIgnorePattern": "^_",
+            "destructuredArrayIgnorePattern": "^_"
+          }
+        ],
     },
 }];

package.json

@@ -93,7 +93,7 @@
     "@types/w3c-web-serial": "^1.0.2",
     "@types/w3c-web-usb": "^1.0.5",
     "@types/wicg-file-system-access": "^2020.9.7",
-    "@typescript-eslint/eslint-plugin": "^4.10.0",
+    "@typescript-eslint/eslint-plugin": "^7.13.0",
     "@typescript-eslint/parser": "^7.11.0",
     "@vitejs/plugin-react-swc": "^3.7.0",
     "babel-eslint": "^10.1.0",

src/actions/firmware.action.ts

@@ -135,8 +135,7 @@ export const firmwareActionsThunk = {
     (file: File): ThunkPromiseAction<void> =>
     async (
       dispatch: ThunkDispatch<RootState, undefined, ActionTypes>,
-      // eslint-disable-next-line no-unused-vars
-      getState: () => RootState
+      _getState: () => RootState
     ) => {
       // eslint-disable-next-line no-undef
       const loadBinaryFile = (file: File): Promise<ArrayBuffer> => {

src/actions/hid.action.ts

@@ -454,8 +454,7 @@ export const hidActionsThunk = {
     (keyboard: IKeyboard): ThunkPromiseAction<void> =>
     async (
       dispatch: ThunkDispatch<RootState, undefined, ActionTypes>,
-      // eslint-disable-next-line no-unused-vars
-      getState: () => RootState
+      _getState: () => RootState
     ) => {
       await keyboard.close();
       dispatch(AppActions.updateSetupPhase(SetupPhase.keyboardNotSelected));
@@ -625,8 +624,7 @@ export const hidActionsThunk = {
       dispatch: ThunkDispatch<RootState, undefined, ActionTypes>,
       getState: () => RootState
     ) => {
-      // eslint-disable-next-line no-unused-vars
-      const { app, entities } = getState();
+      const { entities } = getState();
       const keyboard: IKeyboard = entities.keyboard!;
 
       const rows = entities.keyboardDefinition!.matrix.rows;

src/actions/storage.action.ts

@@ -219,8 +219,7 @@ export const storageActionsThunk = {
     (keyboardDefinition: KeyboardDefinitionSchema): ThunkPromiseAction<void> =>
     async (
       dispatch: ThunkDispatch<RootState, undefined, ActionTypes>,
-      // eslint-disable-next-line no-unused-vars
-      getState: () => RootState
+      _getState: () => RootState
     ) => {
       dispatch(StorageActions.updateKeyboardDefinition(keyboardDefinition));
       dispatch(

src/components/catalog/header/Header.tsx

@@ -22,14 +22,12 @@ class Header extends React.Component<HeaderProps, HeaderState> {
     super(props);
   }
 
-  // eslint-disable-next-line no-unused-vars
-  onClickBackButton(event: SyntheticEvent) {
+  onClickBackButton(_event: SyntheticEvent) {
     sendEventToGoogleAnalytics('catalog/back_to_search');
     this.props.goToSearch!();
   }
 
-  // eslint-disable-next-line no-unused-vars
-  onClickFlashFirmware(event: SyntheticEvent) {
+  onClickFlashFirmware(_event: SyntheticEvent) {
     this.props.openUploadFirmwareDialog!();
   }
 

src/components/catalog/keyboard/keymap/Catalogkeymap.tsx

@@ -48,8 +48,7 @@ export default function CatalogKeymap(props: CatalogKeymapProps) {
 
   const navigate = useNavigate();
 
-  // eslint-disable-next-line no-unused-vars
-  const onClickBackButton = (event: React.MouseEvent<{}>) => {
+  const _onClickBackButton = (_event: React.MouseEvent<{}>) => {
     // eslint-disable-next-line no-undef
     navigate('/catalog');
     props.goToSearch!();
@@ -296,8 +295,7 @@ type LayerProps = {
 
 function Layer(props: LayerProps) {
   const layers = [...Array(props.layerCount)].map((_, i) => i);
-  // eslint-disable-next-line no-unused-vars
-  const invisiblePages = layers.map((layer) => true);
+  const invisiblePages = layers.map((_layer) => true);
   return (
     <div className="catalog-keymap-layer-wrapper">
       <LayerPagination

src/components/common/auth/AuthProviderDialog.container.ts

@@ -3,8 +3,7 @@ import AuthProviderDialog from './AuthProviderDialog';
 import { RootState } from '../../../store/state';
 import { AppActionsThunk } from '../../../actions/actions';
 
-// eslint-disable-next-line no-unused-vars
-const mapStateToProps = (state: RootState) => {
+const mapStateToProps = (_state: RootState) => {
   return {};
 };
 export type AuthProviderDialogStateType = ReturnType<typeof mapStateToProps>;

src/components/configure/importDef/ImportDefDialog.stories.tsx

@@ -17,8 +17,7 @@ export default {
   ],
 };
 
-// eslint-disable-next-line no-unused-vars
-const keyboardDefinition: KeyboardDefinitionSchema = {
+const _keyboardDefinition: KeyboardDefinitionSchema = {
   name: 'Dummy',
   vendorId: hexadecimal(777),
   productId: hexadecimal(1),

src/components/configure/keycodekey/any/AddAnyKeycodeKey.container.ts

@@ -4,8 +4,7 @@ import { RootState } from '../../../../store/state';
 import { AnyKeycodeKeyActions } from '../../../../actions/actions';
 import { AnyKey } from '../KeycodeKey';
 
-// eslint-disable-next-line no-unused-vars
-const mapStateToProps = (state: RootState) => {
+const mapStateToProps = (_state: RootState) => {
   return {};
 };
 export type KeycodeAddKeyStateType = ReturnType<typeof mapStateToProps>;

src/components/configure/keymap/Keymap.tsx

@@ -220,8 +220,7 @@ export default class Keymap extends React.Component<
 
   componentDidUpdate(
     prevProps: KeymapPropsType,
-    // eslint-disable-next-line no-unused-vars
-    prevState: OwnKeymapStateType
+    _prevState: OwnKeymapStateType
   ) {
     if (prevProps.testMatrix !== this.props.testMatrix) {
       clearInterval(this.state.interval);

src/components/configure/lighting/LightingDialog.tsx

@@ -56,12 +56,7 @@ export default class LightingDialog extends React.Component<
     this.state = {};
   }
 
-  shouldComponentUpdate(
-    // eslint-disable-next-line no-unused-vars
-    nextProps: OwnProps,
-    // eslint-disable-next-line no-unused-vars
-    nextState: OwnState
-  ) {
+  shouldComponentUpdate(_nextProps: OwnProps, _nextState: OwnState) {
     this.initLighting();
     return true;
   }

src/components/configure/macroeditor/MacroEditor.tsx

@@ -1,13 +1,11 @@
-/* eslint-disable no-unused-vars */
-/* eslint-disable no-undef */
 import React, { KeyboardEvent } from 'react';
 import './MacroEditor.scss';
 import {
   MacroEditorActionsType,
   MacroEditorStateType,
 } from './MacroEditor.container';
 import { Button } from '@mui/material';
-import { genKey, Key } from '../keycodekey/KeyGen';
+import { genKey } from '../keycodekey/KeyGen';
 import {
   Hold,
   MacroHold,
@@ -467,7 +465,7 @@ export default class MacroEditor extends React.Component<
                         onDelete={(index) => {
                           this.onDelete(index);
                         }}
-                        onChangeType={(index, type) => {
+                        onChangeType={(index, _type) => {
                           this.onToggleKeyType(index);
                         }}
                         onChangeDelay={(index, subIndex) => {

src/components/keyboards/editdefinition/catalogform/CatalogForm.tsx

@@ -79,8 +79,7 @@ export default function CatalogForm(props: CatalogFormProps) {
 
   const onChangeKeyboardType = (
     event: SelectChangeEvent,
-    // eslint-disable-next-line no-unused-vars
-    child: React.ReactNode
+    _child: React.ReactNode
   ): void => {
     props.updateFeature!(
       event.target.value as IKeyboardFeatures,
@@ -90,8 +89,7 @@ export default function CatalogForm(props: CatalogFormProps) {
 
   const onChangeKeyLayout = (
     event: SelectChangeEvent,
-    // eslint-disable-next-line no-unused-vars
-    child: React.ReactNode
+    _child: React.ReactNode
   ): void => {
     props.updateFeature!(
       event.target.value as IKeyboardFeatures,
@@ -192,8 +190,7 @@ export default function CatalogForm(props: CatalogFormProps) {
 
   const onChangeHotSwap = (
     event: SelectChangeEvent,
-    // eslint-disable-next-line no-unused-vars
-    child: React.ReactNode
+    _child: React.ReactNode
   ): void => {
     props.updateFeature!(
       event.target.value as IKeyboardFeatures,
@@ -203,8 +200,7 @@ export default function CatalogForm(props: CatalogFormProps) {
 
   const onChangeOled = (
     event: SelectChangeEvent,
-    // eslint-disable-next-line no-unused-vars
-    child: React.ReactNode
+    _child: React.ReactNode
   ): void => {
     props.updateFeature!(
       event.target.value as IKeyboardFeatures,
@@ -214,8 +210,7 @@ export default function CatalogForm(props: CatalogFormProps) {
 
   const onChangeSpeaker = (
     event: SelectChangeEvent,
-    // eslint-disable-next-line no-unused-vars
-    child: React.ReactNode
+    _child: React.ReactNode
   ): void => {
     props.updateFeature!(
       event.target.value as IKeyboardFeatures,
@@ -225,8 +220,7 @@ export default function CatalogForm(props: CatalogFormProps) {
 
   const onChangeWireless = (
     event: SelectChangeEvent,
-    // eslint-disable-next-line no-unused-vars
-    child: React.ReactNode
+    _child: React.ReactNode
   ): void => {
     props.updateFeature!(
       event.target.value as IKeyboardFeatures,
@@ -285,8 +279,7 @@ export default function CatalogForm(props: CatalogFormProps) {
     props.updateDescription!(description);
   };
 
-  // eslint-disable-next-line no-unused-vars
-  const onClickAddStore = (event: React.MouseEvent<HTMLButtonElement>) => {
+  const onClickAddStore = (_event: React.MouseEvent<HTMLButtonElement>) => {
     setOpenStoreAddDialog(true);
   };
 
@@ -332,8 +325,7 @@ export default function CatalogForm(props: CatalogFormProps) {
     setAdditionalDescriptionBody(additionalDescription.body);
   };
 
-  // eslint-disable-next-line no-unused-vars
-  const onClickAdditionalDescriptionAdd = (event: React.SyntheticEvent) => {
+  const onClickAdditionalDescriptionAdd = (_event: React.SyntheticEvent) => {
     props.addAdditionalDescription!(
       additionalDescriptionTitle,
       additionalDescriptionBody
@@ -801,8 +793,7 @@ export default function CatalogForm(props: CatalogFormProps) {
                     <ListItemSecondaryAction>
                       <IconButton
                         edge="end"
-                        // eslint-disable-next-line no-unused-vars
-                        onClick={(event: React.MouseEvent) => {
+                        onClick={(_event: React.MouseEvent) => {
                           onClickDeleteStore(store);
                         }}
                       >

src/components/keyboards/editdefinition/catalogform/StoreAddDialog.tsx

@@ -40,7 +40,7 @@ export default class StoreAddDialog extends React.Component<
   }
 
   // eslint-disable-next-line no-unused-vars
-  private onClickClose(event: React.MouseEvent) {
+  private onClickClose(_event: React.MouseEvent) {
     this.props.onClose();
   }
 

src/components/organizations/editorganization/EditOrganization.tsx

@@ -179,7 +179,7 @@ export default class EditOrganization extends React.Component<
                                     <IconButton
                                       edge="end"
                                       // eslint-disable-next-line no-unused-vars
-                                      onClick={(event: React.MouseEvent) => {
+                                      onClick={(_event: React.MouseEvent) => {
                                         this.handleDeleteMemberClick(member);
                                       }}
                                       disabled={member.me}

src/components/top/Top.container.ts

@@ -4,7 +4,7 @@ import Top from './Top';
 import { MetaActions } from '../../actions/meta.action';
 
 // eslint-disable-next-line no-unused-vars
-const mapStateToProps = (state: RootState) => {
+const mapStateToProps = (_state: RootState) => {
   return {};
 };
 export type TopStateType = ReturnType<typeof mapStateToProps>;

src/index.tsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import ReactDOM from 'react-dom';
 import './index.scss';
 import { createStore, applyMiddleware } from 'redux';
 import { Provider } from 'react-redux';

src/services/firmware/Command.ts

@@ -44,7 +44,7 @@ export abstract class AbstractCommand<
   }
 
   // eslint-disable-next-line no-unused-vars
-  protected async verify(serial: ISerial): Promise<IResult> {
+  protected async verify(_serial: ISerial): Promise<IResult> {
     return {
       success: false,
       error: 'Verification logic not implemented.',