-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure workspace:
prefix is updated correctly when using PNPM.
#110
Ensure workspace:
prefix is updated correctly when using PNPM.
#110
Conversation
Hmmm. Seems like we should make using Can you create a test here that emulates the repo structure? |
Fwiw, the way glimmer-vm is setup now is that release it isn't used at all for releasing, but we use it for everything else it does. We have a gh workflow that'll release when a tag occurs |
I think we probably need two things:
|
|
#2 is done in this PR, thanks for reviewing! |
Any progress? |
index.js
Outdated
// tools that use this replace with a real version during the publish the process | ||
if (existingVersion.startsWith('workspace:')) { | ||
prefix = 'workspace:'; | ||
range = existingVersion.split(':')[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very very slightly off. Since we are only checking that it starts with workspace:
, we need to slice the beginning instead of split on :
(otherwise, any values that include multiple :
would be mangled incorrectly -- I realize this may not actually be a real thing, but there is no reason to diverge between our guard and the final value).
Updated to existingVersion.slice(prefix.length)
instead.
workspace:
prefix is updated correctly when using PNPM.
I was trying to publish glimmer-vm, and ran in to an issue, noted here: #79 (comment)
I believe this is a reasonable way to move forward with
pnpm
+ "workspace protocol" support, as its opt-in, and existing behavior is unchanged.lemme know what you think, thanks!