fix: Use "422 Unprocessable Entity" when server refuses parcel (#129)

See: AwalaApp/specs@f4ef055
relaycorp · May 14, 2021 · cec782d · cec782d
1 parent 89c7d6c
commit cec782d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/lib/PoWebClient.spec.ts b/src/lib/PoWebClient.spec.ts
@@ -406,8 +406,8 @@ describe('PoWebClient', () => {
       await client.deliverParcel(parcelSerialized, signer);
     });
 
-    test('HTTP 403 should throw a RefusedParcelError', async () => {
-      mockAxios.onPost('/parcels').reply(403, null);
+    test('HTTP 422 should throw a RefusedParcelError', async () => {
+      mockAxios.onPost('/parcels').reply(422, null);
 
       const error = await getRejection(client.deliverParcel(parcelSerialized, signer));
 
@@ -417,7 +417,7 @@ describe('PoWebClient', () => {
 
     test('RefusedParcelError should include rejection reason if available', async () => {
       const message = 'Not enough postage';
-      mockAxios.onPost('/parcels').reply(403, { message });
+      mockAxios.onPost('/parcels').reply(422, { message });
 
       const error = await getRejection(client.deliverParcel(parcelSerialized, signer));
 
@@ -434,7 +434,7 @@ describe('PoWebClient', () => {
       expect(error.message).toEqual('Server was unable to get parcel (HTTP 500)');
     });
 
-    test('HTTP responses other than 20X/403/50X should throw errors', async () => {
+    test('HTTP responses other than 20X/422/50X should throw errors', async () => {
       mockAxios.onPost('/parcels').reply(400, null);
 
       const error = await getRejection(client.deliverParcel(parcelSerialized, signer));

diff --git a/src/lib/PoWebClient.ts b/src/lib/PoWebClient.ts
@@ -182,7 +182,7 @@ export class PoWebClient implements GSCClient {
     }
 
     const errorMessage = response.data?.message;
-    if (response.status === 403) {
+    if (response.status === 422) {
       throw new RefusedParcelError(
         errorMessage ? `Parcel was rejected: ${errorMessage}` : 'Parcel was rejected',
       );