fix: Register gateway on sync

[sdsantos]

Closes #714

Also fixes 2 issues I found:

• Certificates weren't deleted if expired, because that method was called after the never-ending public sync method
• The gateway certificate we received expires after 30 days, and we were always renewing them if the expiration date was less than 90 days (changed to 25 days)

[gnarea]

Thanks!

The PR LGTM but I won't be able to test it today and I want to check a few different scenarios, so I'll approve/merge it tomorrow.

The gateway certificate we received expires after 30 days

Are you sure? I can investigate this tomorrow, but I had a quick check and we're setting it to 6 months, so if the certificate you get expires after 30 days, then that's a bug in the Internet Gateway or the Awala JVM lib... And we shouldn't change that here because it really has to be valid for a few months.

[sdsantos]

The gateway certificate we received expires after 30 days

Are you sure? I can investigate this tomorrow, but I had a quick check and we're setting it to 6 months, so if the certificate you get expires after 30 days, then that's a bug in the Internet Gateway or the Awala JVM lib... And we shouldn't change that here because it really has to be valid for a few months.

Just tested again on a fresh install and the privateNodeCertificate we get back inside the PrivateNodeRegistration is expiring at 2024-01-26T20:56:37Z[Europe/Lisbon].

[gnarea]

It's a bug in the Internet Gateway: I wasn't being alerted to the fact that the daily certificate rotation job is failing, so the last certificate that was successfully generated expires on 26th Jan 2024... Which means that all the certificates it issues will have that expiry date too.

So, can you please undo the change you made to renew the certificate every 25 days?

[sdsantos]

@gnarea reverted.

[gnarea]

Thanks!

[github-actions]

🎉 This PR is included in version 1.8.2 🎉

The release is available on:

• v1.8.2
• GitHub release

Your semantic-release bot 📦🚀