Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcels can no longer be sent to public endpoints #47

Closed
gnarea opened this issue Mar 8, 2021 · 1 comment · Fixed by #50
Closed

Parcels can no longer be sent to public endpoints #47

gnarea opened this issue Mar 8, 2021 · 1 comment · Fixed by #50
Assignees
Labels
bug Something isn't working released

Comments

@gnarea
Copy link
Member

gnarea commented Mar 8, 2021

We missed this side-effect of #45: we no longer have the ability to send parcels to a public endpoint because the PublicThirdPartyEndpoint no longer knows about the public address.

I think we have two options:

  • Add a publicAddress parameter to load() and import(), so that app developers specify it each time.
  • Store the public address on a separate file when the endpoint is import()ed.

I think the latter would be nicer but the former is probably acceptable as a steppingstone.

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎉 This issue has been resolved in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants