Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement (de)serialisation of ping and pong messages #14

Merged
merged 6 commits into from
Mar 10, 2021

Conversation

gnarea
Copy link
Member

@gnarea gnarea commented Mar 8, 2021

No description provided.

@gnarea gnarea force-pushed the ping-serialisation branch from 59f8234 to f85898b Compare March 9, 2021 10:54
ZonedDateTime.now().plusDays(3)
)
val pingMessageSerialized = serializePingMessage(
id.value,
Copy link
Member Author

@gnarea gnarea Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: We should ideally generate a different UUID4 value in the final version of the app.

@gnarea gnarea requested a review from sdsantos March 9, 2021 17:09
@gnarea gnarea marked this pull request as ready for review March 9, 2021 17:09
@gnarea gnarea merged commit f9d940f into master Mar 10, 2021
@gnarea gnarea deleted the ping-serialisation branch March 10, 2021 15:03
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants