Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move certificate storage from PrivateKeyStore to new CertificateStore #372

Merged
merged 9 commits into from
Nov 26, 2021

Conversation

gnarea
Copy link
Member

@gnarea gnarea commented Nov 25, 2021

To help implement relaycorp/awala-gateway-internet#49 and relaycorp/awala-pong#26

Fixes #55.

TODO

  • Remove certs from private key store.

@gnarea gnarea changed the title feat: Create CertificateStore feat: Implement CertificateStore Nov 25, 2021
@gnarea gnarea changed the title feat: Implement CertificateStore feat: Implement abstract CertificateStore Nov 26, 2021
@gnarea gnarea changed the title feat: Implement abstract CertificateStore feat: Move certificate storage from PrivateKeyStore to new CertificateStore Nov 26, 2021
@gnarea gnarea marked this pull request as ready for review November 26, 2021 16:02
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 26, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 26, 2021
@gnarea gnarea added the automerge Allow kodiak to automerge commit when all checks pass label Nov 26, 2021
@kodiakhq kodiakhq bot merged commit 020e40c into master Nov 26, 2021
@kodiakhq kodiakhq bot deleted the cert-store branch November 26, 2021 16:11
@github-actions
Copy link

🎉 This PR is included in version 1.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Nov 26, 2021
…eStore (#372)

To help implement relaycorp/awala-gateway-internet#49 and relaycorp/awala-pong#26

Fixes #55.

TODO

- [x] Remove certs from private key store. [skip ci] 020e40c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement abstract certificate store
1 participant