Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home screen: Ping timeouts take too long to be reflected #28

Closed
gnarea opened this issue Apr 3, 2021 · 1 comment · Fixed by #32
Closed

Home screen: Ping timeouts take too long to be reflected #28

gnarea opened this issue Apr 3, 2021 · 1 comment · Fixed by #32
Assignees
@sdsantos
Labels
bug Something isn't working released

Comments

@gnarea
Copy link
Member

gnarea commented Apr 3, 2021 •
edited
Loading

It takes too long for the status to be reflected on the home screen.

Here's an example of a ping that timed out after 1 minute:

Screenshot_20210403-105607

And this is what it looks like on the home screen after 10 minutes:

Screenshot_20210403-110405

Ideally, these things would be updated in real-time, but I suspect that'd make the implementation too complicated for such an infrequent use case. So as a compromise I'd suggest to re-query the DB when the user goes back to the home screen, for example, after being on the ping screen.
@gnarea gnarea added the bug Something isn't working label Apr 3, 2021
@gnarea gnarea changed the title Ping timeouts take too long to be reflected in the UI Home screen: Ping timeouts take too long to be reflected Apr 3, 2021
@sdsantos sdsantos mentioned this issue Apr 5, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #32 Apr 5, 2021
kodiakhq bot pushed a commit that referenced this issue Apr 5, 2021
@sdsantos
fix: Auto-refresh pings state (#32)
efac185 
Closes #26 
Closes #28 

Now the ping state and dates refresh every 10 seconds by themselves, to handle state changes like a day has passed, or it has expired.
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdsantos sdsantos

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Auto-refresh pings state relaycorp/awala-ping-android
2 participants
@sdsantos @gnarea