Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate certificate store #680

Merged
merged 24 commits into from
Nov 30, 2021
Merged

feat: Integrate certificate store #680

merged 24 commits into from
Nov 30, 2021

Conversation

gnarea
Copy link
Member

@gnarea gnarea commented Nov 30, 2021

So that we can rotate certificates.

Fixes #49

TODO

  • Move certificates from private key store to certificate store.
  • Write migration script.
  • Delete all references to GATEWAY_KEY_ID env var
  • Alter /cogrpc/service.spec.ts to use real MongoDB instead of complicated mocks.
  • Remove retrieveOwnCertificates.
  • Remove all VAULT_* env vars from functional test dir.

@gnarea gnarea marked this pull request as ready for review November 30, 2021 19:49
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 30, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 30, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 30, 2021
@kodiakhq kodiakhq bot merged commit 5a78d88 into master Nov 30, 2021
@kodiakhq kodiakhq bot deleted the cert-store branch November 30, 2021 20:51
@github-actions
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move current gateway key id from environment variable to datastore
1 participant