fix(PoWeb): Use HTTP 422 when parcel is well-formed but invalid

package.json

@@ -23,7 +23,7 @@
     "node": ">=12"
   },
   "devDependencies": {
-    "@relaycorp/relaynet-poweb": "^1.3.19",
+    "@relaycorp/relaynet-poweb": "^1.5.2",
     "@relaycorp/shared-config": "^1.4.13",
     "@relaycorp/ws-mock": "^1.5.0",
     "@semantic-release/exec": "^5.0.0",

src/services/poweb/parcelCollection.spec.ts

@@ -7,8 +7,8 @@ import {
   InvalidMessageError,
   ParcelDelivery,
   Signer,
+  StreamingMode,
 } from '@relaycorp/relaynet-core';
-import { StreamingMode } from '@relaycorp/relaynet-poweb';
 import { CloseFrame, createMockWebSocketStream, MockClient } from '@relaycorp/ws-mock';
 import AbortController from 'abort-controller';
 import bufferToArray from 'buffer-to-arraybuffer';

src/services/poweb/parcelDelivery.spec.ts

@@ -143,7 +143,7 @@ test('Malformed parcels should be refused with an HTTP 400 response', async () =
   expect(fixtures.parcelStore.storeParcelFromPeerGateway).not.toBeCalled();
 });
 
-test('Well-formed yet invalid parcels should be refused with an HTTP 403 response', async () => {
+test('Well-formed yet invalid parcels should be refused with an HTTP 422 response', async () => {
   const logging = makeMockLogging();
   const fastify = await makeServer(logging.logger);
   const fixtures = getFixtures();
@@ -161,7 +161,7 @@ test('Well-formed yet invalid parcels should be refused with an HTTP 403 respons
     makeAuthorizationHeaderValue(countersignature),
   );
 
-  expect(response).toHaveProperty('statusCode', 403);
+  expect(response).toHaveProperty('statusCode', 422);
   expect(JSON.parse(response.payload)).toHaveProperty('message', 'Parcel is invalid');
   expect(logging.logs).toContainEqual(
     partialPinoLog('info', 'Invalid parcel', {

src/services/poweb/parcelDelivery.ts

@@ -82,7 +82,7 @@ export default async function registerRoutes(
       } catch (err) {
         if (err instanceof InvalidMessageError) {
           parcelAwareLogger.info({ err }, 'Invalid parcel');
-          return reply.code(403).send({ message: 'Parcel is invalid' });
+          return reply.code(422).send({ message: 'Parcel is invalid' });
         }
 
         parcelAwareLogger.error({ err }, 'Failed to save parcel');