feat: Integrate service messages #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each parcel encapsulates exactly one Relaynet _service message_ encrypted. This fixes #42. The following changes were also necessary: - Drop `Message.payload`. Its equivalent in a service message is called _content_. - `IncomingMessage.content` supersedes the old `Message.payload`. - `OutgoingMessage` doesn't have an equivalent to the old `.payload` - Capture the service message _type_ in the `Message`s. This type is to be used by app developers to determine how to process the `content`; for example, something like `image/png` could be rendered on screen whilst something like `application/json; type=Tweet` could be JSON-deserialised and verified against a schema. - `OutgoingMessage.build()` now requires the `type`. - `IncomingMessage.type` exposes the `type`. - Promote the identity certificate from the children of `ThirdPartyEndpoint` to the parent class. This is needed to encrypt messages regardless of whether the endpoint is private or public.
sdsantos
approved these changes
Mar 9, 2021
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaynet requires each parcel to encapsulate exactly one service message encrypted. This fixes #42.
The following changes were also necessary:
Message.payload. Its equivalent in a service message is called content.IncomingMessage.contentsupersedes the oldMessage.payload.OutgoingMessagedoesn't have an equivalent to the old.payloadMessages. This type is to be used by app developers to determine how to process thecontent; for example, something likeimage/pngcould be rendered on screen whilst something likeapplication/json; type=Tweetcould be JSON-deserialised and verified against a schema.OutgoingMessage.build()now requires thetype.IncomingMessage.typeexposes thetype.ThirdPartyEndpointto the parent class. This is needed to encrypt messages regardless of whether the endpoint is private or public.