Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose the core Relaynet lib in the public API of this library #33

Closed
gnarea opened this issue Mar 4, 2021 · 2 comments · Fixed by #65
Closed

Don't expose the core Relaynet lib in the public API of this library #33

gnarea opened this issue Mar 4, 2021 · 2 comments · Fixed by #65
Labels
enhancement New feature or request released

Comments

@gnarea
Copy link
Member

gnarea commented Mar 4, 2021

We're using api('tech.relaycorp:relaynet:[1.47.0,2.0.0)') but app developers shouldn't use the core lib at all, so ideally would use implementation(tech.relaycorp:relaynet:1.47.0).

If our public API is exposing the core Relaynet lib, we should change that.
@gnarea gnarea added the enhancement New feature or request label Mar 4, 2021
@gnarea
Copy link
Member Author

gnarea commented Mar 4, 2021

Ah, I think that's because of the Certificates. We should replace those with ByteArrays in the public API.

@gnarea gnarea mentioned this issue Mar 4, 2021
Merged
@sdsantos sdsantos mentioned this issue Mar 16, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #65 Mar 16, 2021
kodiakhq bot pushed a commit that referenced this issue Mar 16, 2021
@sdsantos
fix: Don't expose core lib in Public API (#65)
4c3a077 
Closes #33
@github-actions
Copy link

🎉 This issue has been resolved in version 1.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't expose core lib in Public API relaycorp/awala-endpoint-android
1 participant
@gnarea