Export max size of parcel payload

relaycorp · Oct 28, 2023 · 88dc6da · 88dc6da
1 parent 0fc0c44
commit 88dc6da
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/lib/src/main/java/tech/relaycorp/awaladroid/messaging/Message.kt b/lib/src/main/java/tech/relaycorp/awaladroid/messaging/Message.kt
@@ -1,6 +1,18 @@
 package tech.relaycorp.awaladroid.messaging
 
+import tech.relaycorp.relaynet.ramf.RAMFMessage
+
 /**
  * A service message.
  */
-public abstract class Message
+public abstract class Message {
+    public companion object {
+        private const val PESSIMISTIC_CMS_ENVELOPEDDATA_OVERHEAD_OCTETS = 1024
+
+        /**
+         * The maximum size of the content of a message.
+         */
+        public const val MAX_CONTENT_SIZE: Int =
+            RAMFMessage.MAX_PAYLOAD_LENGTH - PESSIMISTIC_CMS_ENVELOPEDDATA_OVERHEAD_OCTETS
+    }
+}
diff --git a/lib/src/main/java/tech/relaycorp/awaladroid/messaging/OutgoingMessage.kt b/lib/src/main/java/tech/relaycorp/awaladroid/messaging/OutgoingMessage.kt
@@ -44,13 +44,14 @@ private constructor(
         /**
          * Create an outgoing service message (but don't send it).
          *
-         * @param type The type of the message (e.g., "application/vnd.relaynet.ping-v1.ping").
+         * @param type The type of the message (e.g., "application/vnd.awala.ping-v1.ping").
          * @param content The contents of the service message.
          * @param senderEndpoint The endpoint used to send the message.
          * @param recipientEndpoint The endpoint that will receive the message.
          * @param parcelExpiryDate The date when the parcel should expire.
          * @param parcelId The id of the parcel.
          */
+        @Throws(InvalidMessageException::class)
         public suspend fun build(
             type: String,
             content: ByteArray,
@@ -71,6 +72,7 @@ private constructor(
         }
     }
 
+    @Throws(InvalidMessageException::class)
     private suspend fun buildParcel(
         serviceMessageType: String,
         serviceMessageContent: ByteArray,

diff --git a/lib/src/test/java/tech/relaycorp/awaladroid/messaging/MessageTest.kt b/lib/src/test/java/tech/relaycorp/awaladroid/messaging/MessageTest.kt
@@ -0,0 +1,14 @@
+package tech.relaycorp.awaladroid.messaging
+
+import org.junit.Assert
+import org.junit.Test
+import tech.relaycorp.relaynet.ramf.RAMFMessage
+
+public class MessageTest {
+    @Test
+    public fun maxContentSize() {
+        val expectedMax = RAMFMessage.MAX_PAYLOAD_LENGTH - 1024
+
+        Assert.assertEquals(Message.MAX_CONTENT_SIZE, expectedMax)
+    }
+}
diff --git a/lib/src/test/java/tech/relaycorp/awaladroid/messaging/OutgoingMessageTest.kt b/lib/src/test/java/tech/relaycorp/awaladroid/messaging/OutgoingMessageTest.kt
@@ -21,7 +21,6 @@ import kotlin.math.abs
 import kotlin.random.Random
 
 internal class OutgoingMessageTest : MockContextTestCase() {
-
     @Test
     fun build_creationDate() = runTest {
         val channel = createEndpointChannel(RecipientAddressType.PRIVATE)