Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration of XSLT version in Saxon #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdeltour
Copy link

Setting the "XSLT_VERSION" feature on Saxon's TransformerFactory issued a warning on recent Saxon version (9.8+).

According to @michaelkay:

At one time (before 3.0 was finalised) Saxon had the option to operate
as either a 2.0 or a 3.0 conformant processor. If you selected 2.0 (in
the API), then we tried hard to suppress all 3.0 features such as new
functions, xsl:iterate, etc. Simply setting version="2.0" in the
stylesheet doesn't have this effect (3.0 features will still work, so
you don't pass the conformance tests for 2.0). At some later date we
decided we would no longer have a 2.0-conformant mode: if you request
2.0, we fall back to 3.0, so you get the 3.0 features whether you like
it or not. We made this decision because the level of backwards
compatibility between 2.0 and 3.0 is very high, so pretty well all
non-error stylesheets will run unchanged.

This commit removes the code setting the "XSLT_VERSION" feature.

Fix #277.

Setting the "XSLT_VERSION" feature on Saxon's `TransformerFactory`
issued a warning on recent Saxon version (9.8+).

According to @michaelkay:

> At one time (before 3.0 was finalised) Saxon had the option to operate
> as either a 2.0 or a 3.0 conformant processor. If you selected 2.0 (in
> the API), then we tried hard to suppress all 3.0 features such as new
> functions, xsl:iterate, etc. Simply setting version="2.0" in the
> stylesheet doesn't have this effect (3.0 features will still work, so
> you don't pass the conformance tests for 2.0). At some later date we
> decided we would no longer have a 2.0-conformant mode: if you request
> 2.0, we fall back to 3.0, so you get the 3.0 features whether you like
> it or not. We made this decision because the level of backwards
> compatibility between 2.0 and 3.0 is very high, so pretty well all
> non-error stylesheets will run unchanged.

This commit removes the code setting the "XSLT_VERSION" feature.

Fix relaxng#277.
@ndw ndw self-requested a review December 12, 2022 14:17
Copy link
Contributor

@ndw ndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Warning XSLT version ignored" output when using Jing with Saxon 11.4
2 participants