Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to run test suite #269

Open
datho7561 opened this issue Sep 27, 2022 · 5 comments · May be fixed by #270
Open

How to run test suite #269

datho7561 opened this issue Sep 27, 2022 · 5 comments · May be fixed by #270

Comments

@datho7561
Copy link

The repository says that there is a test suite that I should be able to run with ant test, but this doesn't work. How do I run the test suite?

Initial investigation:

In a recent change, the ant task in build.xml for running the tests was renamed to ant-test to distinguish it from gradle tasks. gradle test isn't setup to run this task yet. When I try to run ant ant-test, I get an error, saying that modbuild.xml doesn't have ant-test. The generated modbuild.xml has a test task, so it's likely just a matter of running the correct modbuild.xml task from build.xml.
datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 27, 2022
@datho7561
WIP run tests using gradle test
2100202 
As of now, the tests fail, likely due to https://saxonica.plan.io/issues/2212.

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 27, 2022
@datho7561
WIP run tests using gradle test
37db211 
As of now, the tests fail, likely due to https://saxonica.plan.io/issues/2212.

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
@datho7561
Copy link
Author

It seems like the test suite fails because it uses features of Saxon-EE that the version of Saxon in this repo doesn't support. This suggests to me that Saxon-B was used in this repo at some point, which supported some Saxon-EE features, but then the repo switch over to Saxon-HE (perhaps in f45d16d?).

Then again, one of the Saxon-EE features being used is used to reflexively call Java code to create a directory on the filesystem using the java.io.File API. Micheal Kay said on Stack Overflow that using side effects with this Saxon feature is a bad idea, so maybe its worthwhile to investigate if this can be done somewhere else in the code.

datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 29, 2022
@datho7561
Run tests with gradle test
dcec5f6 
* Update the docs to explain how to run tests
* Create GitHub Actions CI to replace Travis CI

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 29, 2022
@datho7561
Run tests with gradle test
b2ff431 
* Update the docs to explain how to run tests
* Create GitHub Actions CI to replace Travis CI

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 29, 2022
@datho7561
Run tests with gradle test
f59366b 
* Update the docs to explain how to run tests
* Create GitHub Actions CI to replace Travis CI

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 29, 2022
@datho7561
Run tests with gradle test
1dc2abf 
* Update the docs to explain how to run tests
* Create GitHub Actions CI to replace Travis CI

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 29, 2022
@datho7561
Run tests with gradle test
a75f26a 
* Update the docs to explain how to run tests
* Create GitHub Actions CI to replace Travis CI

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/jing-trang that referenced this issue Sep 29, 2022
@datho7561
Run tests with gradle test
7d5db84 
* Update the docs to explain how to run tests
* Create GitHub Actions CI to replace Travis CI

Closes relaxng#269

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 linked a pull request Sep 29, 2022 that will close this issue
Open
@sjvudp
Copy link

sjvudp commented Sep 29, 2023

Just downloaded and built "master" with "BUILD SUCCESSFUL", but "test" doesn't work (on openSUSE 15.5) it seems:

Projects/jing-trang> ./ant test
Buildfile: ./build.xml

BUILD FAILED
Target "test" does not exist in the project "jing-trang". 

Total time: 0 seconds

@datho7561
Copy link
Author

@sjvudp I have a PR open to fix the test suite. If you are interested in running the tests, please check it out. It seems like this repo hasn't been active in a while, so I don't know if it will get merged. Also, I'm not sure who is still active on this repo to ask for a review.

@ndw
Copy link
Contributor

ndw commented Sep 29, 2023

I expect we're all still around, but I've been a bit swamped with other things and I'm not sure I was ever that sure I understood how the build system worked.

@sjvudp
Copy link

sjvudp commented Oct 11, 2023

I expect we're all still around, but I've been a bit swamped with other things and I'm not sure I was ever that sure I understood how the build system worked.

I see two options:

  1. Merge the branch that claims to have fixed the issue
  2. Modify the docs, stating that the "./ant test" is broken and needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run tests with gradle test datho7561/jing-trang
3 participants
@ndw @sjvudp @datho7561