Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic Language (ar) #824

Open
hmg3099 opened this issue Dec 1, 2024 · 6 comments
Open

Arabic Language (ar) #824

hmg3099 opened this issue Dec 1, 2024 · 6 comments

Comments

@hmg3099
Copy link

hmg3099 commented Dec 1, 2024

hfs-lang-ar.txt

here is an Arabic language

@hmg3099
Copy link
Author

hmg3099 commented Dec 1, 2024

hfs-lang-ar.txt

updated .... sorry

@rejetto
Copy link
Owner

rejetto commented Dec 1, 2024

thank you!
are you already using this? is visualization correct? no problem because of the right-left direction?

@hmg3099
Copy link
Author

hmg3099 commented Dec 3, 2024

Yesterday, I fully tested the translation and found that it appeared improperly on some places due to button alignment issues. To address this, I added a line in the stylesheet to adjust the direction to right-to-left, which resolved the issue in some areas but didn’t work for others. I’ll try to upload my findings tonight along with screenshots.

@rejetto
Copy link
Owner

rejetto commented Dec 3, 2024

thank you.
I never designed or tested the system with a right-left language, as I don't have the necessary knowledge.
If it is necessary, I will make possibile for the translation to decide the direction, or whatever else is needed.

@hmg3099
Copy link
Author

hmg3099 commented Dec 5, 2024

hfs-lang-ar.txt
updated translation file
I implemented the following code, and the result was excellent. However, there are a few areas that need adjustments, mainly related to margins. I will attach images to highlight these issues

This is without the direction-changing code.
File server · 8 14am · 06-04
File server · 8 17am · 06-04
File server · 8 17am · 06-04 (1)

This is with the direction-changing code " body { direction:rtl; } "
File server
File server · 8 16am · 06-04
File server · 8 20am · 06-04

@rejetto
Copy link
Owner

rejetto commented Dec 5, 2024

the rtl version doesn't look good to me, but i'm also not used to it.
For example
image
is it ok (once in arabic, of course) that "3 files" becomes "files, ......... 3" ?

rejetto added a commit that referenced this issue Dec 6, 2024
rejetto added a commit that referenced this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants