Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

feat: rename output APK with info about the build #192

Merged
merged 9 commits into from
Aug 8, 2022
Merged

feat: rename output APK with info about the build #192

merged 9 commits into from
Aug 8, 2022

Conversation

shrihankp
Copy link
Collaborator

@shrihankp shrihankp commented Aug 8, 2022

closes #180

@reisxd
Copy link
Owner

reisxd commented Aug 8, 2022

Does it use the old signature or creates a new one? (reading code on mobile is pain)

@shrihankp
Copy link
Collaborator Author

old signature

???

@reisxd
Copy link
Owner

reisxd commented Aug 8, 2022

old signature

???

I mean, the old keystore file.

@shrihankp
Copy link
Collaborator Author

keystore file

That's up to ReVanced CLI... Wait, I get it, it always creates a new one based on the filename, shit.

@reisxd
Copy link
Owner

reisxd commented Aug 8, 2022

You can rename the app later or use the keystore flag.

@shrihankp
Copy link
Collaborator Author

@reisxd Added a 'fix'.

@reisxd reisxd merged commit dfe15b3 into reisxd:main Aug 8, 2022
@shrihankp
Copy link
Collaborator Author

shrihankp commented Aug 8, 2022

Btw,

reading code on mobile is pain

Screenshot_2022-08-08-20-47-22-30
I wrote this on my mobile 🗿

"Oh, I'm the king of patience and perseverance. <insert Khalimov> How'd you know?"

@reisxd
Copy link
Owner

reisxd commented Aug 8, 2022

Btw,

reading code on mobile is pain

Screenshot_2022-08-08-20-47-22-30
I wrote this on my mobile 🗿

"Oh, I'm the king of patience and perseverance. <insert Khalimov> How'd you know?"

Makes me one of my friend, @VoltrexMaster (he used to code on his phone, until he got a laptop)

@shrihankp
Copy link
Collaborator Author

shrihankp commented Aug 8, 2022

Now he's contributing to nodejs and llvm 😱🫡

@reisxd
Copy link
Owner

reisxd commented Aug 8, 2022

Now he's contributing to nodejs and llvm 😱🫡

Yep, he's really pog (he's also maintaning both of them).

@reisxd
Copy link
Owner

reisxd commented Aug 8, 2022

@shrihanDev you
Screenshot_2022-08-08-18-38-01-974_com.reddit.frontpage.jpg

@shrihankp
Copy link
Collaborator Author

💀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Rename resulting file to actual app name
2 participants