Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #8

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Update README.md #8

merged 3 commits into from
Jul 24, 2023

Conversation

ameenalasady
Copy link
Contributor

@ameenalasady ameenalasady commented Jul 23, 2023

Improved a lot on wording. Fixed ambiguous sentences.

README.md Outdated

* Run `cd .. && node .`
- A PC capable of running Tizen Studio, which will be used to install TizenStudio onto your TV through SDB.
- A PC or Single Board Computer capable of running 24/7 (for ease of use) or the Android App. Your TV connects to the debugger and sends JS code to this debugger that removes video ads.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your TV connects to the debugger and sends JS code to this debugger that removes video ads.

The TV starts a debugger session once TizenTube starts the app by using the debug <app.id> command. This sentence sounds like the TV itself connects to the debugger then sends JS code to itself (which is technically possible, but too hard to maintain).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
1. First, change the Developer Mode's Host IP to your device's IP.
2. Download the latest APK compatible with your device's architecture from [here](https://github.com/reisxd/TizenTube/releases/tag/v1.1.2) (if unsure, download armeabi-v7a).
3. Install it.
4. After opening the app, change the configuration to suit your needs. Ensure that you set the `appID` to `Ad6NutHP8l.TizenTube` if it isn't already set. Change the IP to match that of your TV.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appID is already set to Ad6NutHP8l.TizenTube once you install TizenTube Server on Android.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this because it is difficult for the average user to get this userid again if they accidentally deleted it. I initially thought it was just an arbitrary name but later discovered that it is not. Maybe it would be a good idea to make it uneditable on the Android app?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you clear the data of the app, it should go back to default configuration.

Copy link
Contributor Author

@ameenalasady ameenalasady Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. Left it in just to avoid confusion (like what happened to me).

Copy link
Owner

@reisxd reisxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the comments I made.

@ameenalasady
Copy link
Contributor Author

I have made the requested changes and pushed them to the remote repository. Please let me know if there is anything else you need to be changed.

Copy link
Owner

@reisxd reisxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this and we're all set.

README.md Outdated Show resolved Hide resolved
@ameenalasady
Copy link
Contributor Author

Done.

@reisxd reisxd merged commit c897753 into reisxd:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants