Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about TypeScript support #2247

Merged
merged 22 commits into from
Apr 4, 2022
Merged

Add info about TypeScript support #2247

merged 22 commits into from
Apr 4, 2022

Conversation

EugeniyBurmistrov
Copy link
Contributor

No description provided.

@EugeniyBurmistrov EugeniyBurmistrov added the docs Documentation related changes label Mar 2, 2022
@const314 const314 changed the title Add info about TypeScrip support Add info about TypeScript support Mar 31, 2022
albertov05
albertov05 reviewed Mar 31, 2022
View reviewed changes
docs/api/command.md Outdated Show resolved Hide resolved
albertov05
albertov05 reviewed Mar 31, 2022
View reviewed changes
docs/api/command.md Outdated Show resolved Hide resolved
albertov05
albertov05 reviewed Mar 31, 2022
View reviewed changes
docs/api/read-model/projection.md
- Package - `@resolve-js/core`

:::

A read model projection is an object of the following structure:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the following line below:

Line 14:
// and updates the store based on the event's data

Please add a period at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

albertov05
albertov05 reviewed Apr 1, 2022
View reviewed changes
docs/api/monitoring/monitoring.md Outdated

:::

A monitoring object's interface is the same as the interface of a monitoring adapter except for the [`getMetrics`](#getmetrics) and [`clearMetrics`](#clearmetrics) methods that require a monitoring adapted ID as an argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the sentence. I noticed one more thing.
Is "a monitoring adapted ID" correct, or do you mean "a monitoring adaptor ID"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed the typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@EugeniyBurmistrov EugeniyBurmistrov merged commit 66493d5 into dev Apr 4, 2022
@EugeniyBurmistrov EugeniyBurmistrov deleted the docs/using-ts branch April 4, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertov05 albertov05 albertov05 left review comments

@const314 const314 const314 approved these changes

@resolve-bot resolve-bot Awaiting requested review from resolve-bot resolve-bot is a code owner

Assignees
No one assigned
Labels
docs Documentation related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EugeniyBurmistrov @const314 @albertov05