Advanced testing tools: improvements #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
max-vasin
commented
Apr 15, 2021
max-vasin
commented
- saga: mockable commands implementations
- saga: mockable queries implementations
- saga: convenient failure output
const314
approved these changes
Apr 15, 2021
aleks-pro
reviewed
Apr 16, 2021
| }) | ||
|
|
||
| test('shouldExecuteCommand failure output should contain all executed commands', async () => { | ||
| try { |
There was a problem hiding this comment.
In that way we will never know if shouldExecuteCommand method stops to fail. And the same for the next two tests.
|
|
||
| if (environment.isExecuted()) { | ||
| throw Error( | ||
| `Command implementation cannot be mocked if the test was executed.` |
There was a problem hiding this comment.
Suggested change
| `Command implementation cannot be mocked if the test was executed.` | |
| `Command implementation cannot be mocked if the test is finished.` |
?
/cc @EugeniyBurmistrov
There was a problem hiding this comment.
The original phrase and the edit mean different things. The edit is indeed correct if the message's indended meaning was "is already finished" and not "was invoked and possibly still runs".
max-vasin
added
the
enhancement
max-vasin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.