Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime code is erroneously executed at compile-time #2114

Closed
IhostVlad opened this issue Nov 10, 2021 · 0 comments · Fixed by #2135
Closed

Runtime code is erroneously executed at compile-time #2114

IhostVlad opened this issue Nov 10, 2021 · 0 comments · Fixed by #2135
Assignees
Labels
breaking Use to mark breaking PR bug Issues related to defects and incorrect/unexpected feature behavior severity: moderate Issues with medium impact on the product, e.g., new features, non-critical defects, etc.

Comments

@IhostVlad
Copy link
Contributor

Describe the bug
Since undocumented changes in 0.33.X framework version, runtime code can be erroneously executed at compile-time

To Reproduce
Steps to reproduce the behaviour:

  1. Create any reSolve example via create-resolve-app tool, for instance hacker-news, i.e. npx [email protected] -e hacker-news -t hn-33
  2. Run something like AWS_XRAY_DAEMON_ADDRESS=qqq yarn cloud in example directory
  3. See output with live executing runtime code in compile-time phase

Expected behaviour
Compile time phase should not involve execution of runtime code, including any dependencies. Compiler should only perform transpiling and bundling, but should not execute any customer and dependencies code at compile-time

Desktop (please complete the following information):

  • OS: MacOs Big Sur 11.3
  • Node.js Version 14.17.6
  • ReSolve Version 0.33.0

Additional context
Compile/runtime phases isolation had been broken here https://github.com/reimagined/resolve/blob/dev/packages/tools/scripts/src/alias/%24resolve.backendEntry.js#L58-L59 in this ~10K LOC changes commit 2be44e3

@IhostVlad IhostVlad added bug Issues related to defects and incorrect/unexpected feature behavior severity: moderate Issues with medium impact on the product, e.g., new features, non-critical defects, etc. breaking Use to mark breaking PR labels Nov 10, 2021
@MrCheater MrCheater assigned MrCheater and unassigned max-vasin Nov 18, 2021
MrCheater added a commit that referenced this issue Nov 18, 2021
@MrCheater MrCheater mentioned this issue Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Use to mark breaking PR bug Issues related to defects and incorrect/unexpected feature behavior severity: moderate Issues with medium impact on the product, e.g., new features, non-critical defects, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants