Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Actions CI #168

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Enable GitHub Actions CI #168

merged 3 commits into from
Nov 20, 2020

Conversation

stefanor
Copy link
Contributor

Some CI to keep tests passing.

Had to unpin versions in requirements.txt for them to be installable. You may want to have a separate test-requirements, or just script the unpinning in the test job.

PyQt5-sip wheels are only built for specific Python versions, so pins
restrict from testing on a wide range of Python versions.
@reilleya
Copy link
Owner

Looks good! One comment but otherwise I think this is ready to merge. I hadn't realized that github has built in CI.

This is another case of something that I should have documented, but there is a pylintrc file checked in that we should have this use if switching it isn't too difficult. If I remember correctly, much of the UI code raises low level warnings while the simulation code is pretty clean.

@stefanor
Copy link
Contributor Author

I had a look, but can't see an obvious way to do anything useful with pylint.

Pylint gives very granular feedback, so you don't want to use it as a pass/fail check, you rather want something to comment on every line of the MR that generates feedback. I think github actions can do that. But I haven't dug in at that level, and I'm not going to for a drive by PR :)

So, probably simple enough to swap that (stock template) flake8 with a pass/fail pylint. But more than that is more complex.

@reilleya
Copy link
Owner

Makes sense. I'll into using pylint in the future but this seems good for now.

Thanks!

@reilleya reilleya merged commit 33875e5 into reilleya:staging Nov 20, 2020
@stefanor stefanor deleted the ci branch November 28, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants