-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade terraform and provider versions #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
much nicer tf state names: module.custom_dns_static_site.azurerm_app_service_custom_hostname_binding.static_site["@"] module.custom_dns_static_site.azurerm_app_service_custom_hostname_binding.static_site["deeper.subdomain"] module.custom_dns_static_site.azurerm_app_service_custom_hostname_binding.static_site["www"]
they stopped supporting proxies.json functionality
counts break if you reorder the list or items (trying to delete and add items that already exist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
count
tofor_each
. Usingcount
can be buggy when items in a list are changed. If you're creating objects and their state index changes, Terraform will try to update both at once or remove/add at the same time leading to conflicts where you have to retry a number of times. Usingfor_each
instead gives more stable state names. Ex:module.custom_dns_static_site.azurerm_app_service_custom_hostname_binding.static_site["www"]
instead ofmodule.custom_dns_static_site.azurerm_app_service_custom_hostname_binding.static_site[0]
.0.14
.2.4.0
to the current version,2.9.0
.azurerm_function_app
andazurerm_app_service_plan
resource for the newerazurerm_linux_function_app
andazurerm_service_plan
.azurerm_linux_function_app
in that some properties (custom_domain_verification_id, default_hostname) are not yet implemented. There are already a couple of MRs that are just awaiting responses from Hashicorp.azurerm_function_app
data reference as a workaround. This will be removed as soon as the missing functionality is released.