fix: Use correct varname for closed appenders #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I propose to change |
|
ping |
firstsano
approved these changes
Aug 26, 2024
|
ping +1 |
ixti
force-pushed
the
fix-appenders-close
branch
from
093c025 to
ce574f8
Compare
|
@reidmorrison is there any chance this small fix will be merged & released any time soon? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
SemanticLogger::Appenders#closeDescription of changes
Backported (from v5) changes to
#closetrack list of closed appenders. Unfortunately, the variable name used for tracking isclosed_appenders, while in the loop we're trying to add the closed appender into non-existing variableappenders.This patch fixes the issue. Also, I moved
closed_appenders << appenderafter the fact of closure, so that the returned list is correct in case of eitherflushorclosefailed.Closes: #291
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.