Allow SyncProcessor to be called from appenders #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyncProcessor#log could be called recursively from an appender like Bugsnag and Sentry.
Issue # (if available)
#281
Changelog
Allow SyncProcessor to be called from appenders
Description of changes
SyncProcessor#log could be called recursively from an appender like Bugsnag and Sentry. However, SyncProcessor doesn't allow it because it uses Mutex to protect SyncProcessor#log. Here are code snippets to reproduce the Mutex error.
This PR resolves the issue by replacing Mutex with Monitor. Monitor allows to enter the critical section if the Mutex's owner is the current thread.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.