update default value of forecast_date_window_size (close issue #93)

reichlab · Jan 4, 2021 · d77ccf1 · d77ccf1
1 parent c66d89a
commit d77ccf1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -6,6 +6,7 @@
 - More user friendly color palettes when plotting a small number of intervals.
 - Add `preprocess_truth_for_zoltar()` and `save_truth_for_zoltar()` for generating truth file for zoltar.
 - Update `get_model_designations()` to return `NA` when model designations for outdated models are not available on Zoltar.
+- Update default value of `forecast_date_window_size` to 0 in`load_latest_forecasts()` so that it looks for forecasts on the `latest_forecast_date` only.
 
 ## covidHubUtils 0.1.2
 

diff --git a/R/load_latest_forecasts.R b/R/load_latest_forecasts.R
@@ -9,8 +9,8 @@
 #' in 'yyyy-mm-dd' format. Defaults to the most recent forecast date in 
 #' Zoltar or the hub repo.
 #' @param forecast_date_window_size The number of days across which to 
-#' look for recent forecasts. Defaults to 1, which means to only look 
-#' at the last_forecast_date. 
+#' look for recent forecasts. Defaults to 0, which means to only look 
+#' at the last_forecast_date only. 
 #' @param locations list of fips. Defaults to all locations with available forecasts.
 #' @param types Character vector specifying type of forecasts to load: “quantile” 
 #' or “point”. Defaults to c(“quantile”, “point”)
@@ -29,7 +29,7 @@
 load_latest_forecasts <- function (
   models,
   last_forecast_date,
-  forecast_date_window_size = 1,
+  forecast_date_window_size = 0,
   locations,
   types,
   targets,

diff --git a/man/load_latest_forecasts.Rd b/man/load_latest_forecasts.Rd