Adds option for adding a prefix #15
Conversation
github-actions
bot
added
👋 phase/new
|
@wooorm just a reminder: you should leave out the edits on |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 28 37 +9
=========================================
+ Hits 28 37 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Thanks! Couple of improvements you can apply. Can you also run npm test to check everything and format everything?
Finally, this needs docs: you can take the text from the JSDoc, and here’s an example of how we document options: https://github.com/rehypejs/rehype-autolink-headings#unifieduserehypeautolinkheadings-options.
| 'should match' | ||
| ) | ||
| } | ||
| ) |
There was a problem hiding this comment.
Some of your code doesn’t match our code style. Please run npm test
Co-authored-by: Titus <[email protected]>
|
Should I also add to the documentation an example with prefixing? |
This project is so small that I don’t think it’s needed! |
wooorm
added
🦋 type/enhancement
This comment has been minimized.
This comment has been minimized.
|
Thanks, released in 5.1! |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [rehype-slug](https://togithub.com/rehypejs/rehype-slug) | [`^5.0.1` -> `^5.1.0`](https://renovatebot.com/diffs/npm/rehype-slug/5.0.1/5.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>rehypejs/rehype-slug</summary> ### [`v5.1.0`](https://togithub.com/rehypejs/rehype-slug/releases/tag/5.1.0) [Compare Source](https://togithub.com/rehypejs/rehype-slug/compare/5.0.1...5.1.0) - [`899b3b7`](https://togithub.com/rehypejs/rehype-slug/commit/899b3b7) Add `options.prefix` by [@​onyxcodes](https://togithub.com/onyxcodes) in [https://github.com/rehypejs/rehype-slug/pull/15](https://togithub.com/rehypejs/rehype-slug/pull/15) **Full Changelog**: rehypejs/rehype-slug@5.0.1...5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC45LjIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Initial checklist
Description of changes
Fixes #14