-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Knife back stab multiplier customizable #834
Conversation
Write the whole word ("*iplier")! |
Thanks you for your observation. I did not add the REGAMEDLL_ADD macro because the written CKnife modification members, the ones preceded by m_flStab/m_flSwing, were not programmed under the above clauses, so I did a wild guess by just extending it. That should be reviewed by the repo maintainers. What do you think? About the Mult suffix, it is between unnecessary but sane, so I'll wait for someones commentary about it. If you have anything else to add I'll be glad to see it. |
Yeah knowing this maybe it can be skipped & so not added, or, added from "m_flStabBaseDamage" if they decide to.
I recommend it, a proper & complete name does not hurt! |
- Added forgotten macros to last commit that included members used mostly on API - Added inline functions for specific values, considering original and new behaviour - Mult -> Multiplier
I ended adding what you wrote here :) @s1lentq some sort of possibility to check this out, and some future ones? Got time for editing and extending this repo |
@dystopm |
Thing is, ReAPI module should be edited and add the last member added to the member table, it isn't enough with editing the include. In other hand, Minor version should be updated in both ReGameDLL and ReAPI, so you can track changes correctly. There are plenty of API upgrades as pull requests so it depends of repo maintainers to merge one of these and update minor version, forcing ReAPI to be updated also. |
title
Feature addition, plus a few line changes, up to modders preferences.