Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little code cleaning: g_vecAttackDir #831

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

dystopm
Copy link
Contributor

@dystopm dystopm commented May 16, 2023

Same argument as #830 : variables used as parameters, mostly used in a old fashioned programming way and on singleplayer hlsdk branch.

Might be useless but opens mind about certain code that should be reviewed in detail.

@s1lentq
Copy link
Collaborator

s1lentq commented Jul 10, 2023

There's no need to wrap in a macro REGAMEDLL_FIXES for each change, except when the behavior does change, so in this case it's just a refactoring and I would prefer not to add this the macro.

p.s We shouldn't be concerned about the fact that with these minor changes we can break compatibility 3-rd party things when they use memhacks.

@dystopm
Copy link
Contributor Author

dystopm commented Jul 10, 2023

There's no need to wrap in a macro REGAMEDLL_FIXES for each change, except when the behavior does change, so in this case it's just a refactoring and I would prefer not to add this the macro.

p.s We shouldn't be concerned about the fact that with these minor changes we can break compatibility 3-rd party things when they use memhacks.

Thanks for your observation, I'll keep in mind this next time 🙌 commit done now

@SergeyShorokhov SergeyShorokhov self-requested a review July 10, 2023 22:59
@SergeyShorokhov SergeyShorokhov added the Priority: 🕒 low Low priority tasks that can be postponed for the future. label Jul 10, 2023
@SergeyShorokhov SergeyShorokhov merged commit 6375ea5 into rehlds:master Jul 11, 2023
@dystopm dystopm deleted the code-clean-2 branch July 14, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 🕒 low Low priority tasks that can be postponed for the future.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants